Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI #19

Merged
merged 5 commits into from
Apr 29, 2024
Merged

Fix CI #19

merged 5 commits into from
Apr 29, 2024

Conversation

IAlibay
Copy link
Member

@IAlibay IAlibay commented Apr 28, 2024

Fixes #18

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

@IAlibay IAlibay requested a review from orbeckst April 28, 2024 21:02
@codecov Codecov
Copy link

codecov bot commented Apr 28, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.84%. Comparing base (5699b0b) to head (1126348).

Additional details and impacted files

orbeckst
orbeckst approved these changes Apr 29, 2024
View reviewed changes
Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

Maybe add comment(s) for future maintainers.

.github/workflows/gh-ci.yaml Outdated Show resolved Hide resolved
@IAlibay IAlibay mentioned this pull request Apr 29, 2024
Open
@IAlibay IAlibay merged commit dac4cd6 into main Apr 29, 2024
20 checks passed
@IAlibay IAlibay deleted the fix-ci branch April 29, 2024 17:55
@orbeckst orbeckst mentioned this pull request May 2, 2024
Closed
@orbeckst orbeckst linked an issue May 2, 2024 that may be closed by this pull request
[CI] Remove exclusion of MDAnalysis "latest" and Python 3.12 from test matrix #20
Open
@orbeckst orbeckst removed a link to an issue May 2, 2024
[CI] Remove exclusion of MDAnalysis "latest" and Python 3.12 from test matrix #20
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orbeckst orbeckst orbeckst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Python 3.9 CI failing
2 participants
@IAlibay @orbeckst